Submission Details
Severity:
Emitting an incorrect event name
Summary
The setPassword() emits an incorrect event name.
Vulnerability Details
The SetNetPassword event, which is an incorrect event name, will be emitted when a new password is set through the setPassword().
function setPassword(string memory newPassword) external {
s_password = newPassword;
@> emit SetNetPassword();
}
https://github.com/Cyfrin/2023-10-PasswordStore/blob/856ed94bfcf1031bf9d13514cb21b591d88ed323/src/PasswordStore.sol#L28
Impact
The setPassword() is an essential function. Emitting an incorrect event name leads to the incorrect logging of important events.
Tools Used
Manual Review
Recommendations
Rename the event to SetNewPassword.
Updates
Rewards breakdown
nSLOC
20This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.