Beginner FriendlyFoundry
100 EXP
View results
Submission Details
Severity: low
Invalid

Informational and Best Practices

Summary

The spelling of new in the event SetNetPassword is wrong
The s_Owner variable should be set to immutable

Vulnerability Details

The spelling of new in the event SetNetPassword is wrong. This could be confusing when referring to the logged events in the future.
The s_Owner variable should not change after deployment. As it is not immutable it will not be read-only and could be subject to change.

Impact

Informational
Unnecessary gas will be used when evaluating against s_Owner

Tools Used

Foundry, Solidity Visual Developer, Slither, VS Code

Recommendations

Fix spelling by renaming to SetNewPassword: event SetNewPassword();
Add immutable keyword to s_Owner and for best pratice, rename s_Owner to i_Owner.

Updates

Lead Judging Commences

inallhonesty Lead Judge
almost 2 years ago
inallhonesty Lead Judge almost 2 years ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.