Submission Details
Severity:
isActivePlayer() will always return false
Summary
isActivePlayer() will always return false
Vulnerability Details
In PuppyRaffle.sol::_isActivePlayer() will always return false
function _isActivePlayer() internal view returns (bool) {
for (uint256 i = 0; i < players.length; i++) {
if (players[i] == msg.sender) {
return true;
}
}
return false;
}
Impact
All the functionality depending on this function will revert
Tools Used
manual review
Recommendations
move return false to an else block
- for (uint256 i = 0; i < players.length; i++) {
if (players[i] == msg.sender) {
return true;
}
}
return false;
+ for (uint256 i = 0; i < players.length; i++) {
if (players[i] == msg.sender) {
return true;
} else return false;
}
Rewards breakdown
nSLOC
143This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.