Beginner FriendlyFoundryNFT
100 EXP
View results
Submission Details
Severity: low
Invalid

Non usable method

[L-2] Non referenced method

Description:

_isActivePlayer method never used

Impact:

Low

Tools used:
manual

Recommended mitigation:

diff --git a/src/PuppyRaffle.sol b/src/PuppyRaffle.sol
index 3a1f85e..38b9ad6 100644
--- a/src/PuppyRaffle.sol
+++ b/src/PuppyRaffle.sol
@@ -167,16 +167,6 @@ contract PuppyRaffle is ReentrancyGuard, ERC721, Ownable {
emit FeeAddressChanged(newFeeAddress);
}
- /// @notice this function will return true if the msg.sender is an active player
- function _isActivePlayer() internal view returns (bool) {
- for (uint256 i = 0; i < players.length; i++) {
- if (players[i] == msg.sender) {
- return true;
- }
- }
- return false;
- }
-
/// @notice this could be a constant variable
function _baseURI() internal pure returns (string memory) {
return "data:application/json;base64,";
Updates

Lead Judging Commences

patrickalphac Lead Judge over 1 year ago
Submission Judgement Published
Invalidated
Reason: Gas optimizations

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.