Submission Details
Severity:
Variables that are not changed after construction should be constant or immutable
[L-5] Variables that are not changed after construction should be constant or immutable
Description:
Variables that are not changed after construction should be constant or immutable
Impact:
Low
Tools used:
manual
Recommended mitigation:
diff --git a/src/PuppyRaffle.sol b/src/PuppyRaffle.sol
index 3a1f85e..1fa34d8 100644
--- a/src/PuppyRaffle.sol
+++ b/src/PuppyRaffle.sol
contract PuppyRaffle is ReentrancyGuard, ERC721, Ownable {
uint256 public immutable entranceFee;
address[] public players;
- uint256 public raffleDuration;
+ uint256 public immutable raffleDuration;
uint256 public raffleStartTime;
address public previousWinner;
contract PuppyRaffle is ReentrancyGuard, ERC721, Ownable {
mapping(uint256 => string) public rarityToName;
// Stats for the common puppy (pug)
- string private commonImageUri = "ipfs://QmSsYRx3LpDAb1GZQm7zZ1AuHZjfbPkD6J7s9r41xu1mf8";
+ string private constant commonImageUri = "ipfs://QmSsYRx3LpDAb1GZQm7zZ1AuHZjfbPkD6J7s9r41xu1mf8";
uint256 public constant COMMON_RARITY = 70;
string private constant COMMON = "common";
// Stats for the rare puppy (st. bernard)
- string private rareImageUri = "ipfs://QmUPjADFGEKmfohdTaNcWhp7VGk26h5jXDA7v3VtTnTLcW";
+ string private constant rareImageUri = "ipfs://QmUPjADFGEKmfohdTaNcWhp7VGk26h5jXDA7v3VtTnTLcW";
uint256 public constant RARE_RARITY = 25;
string private constant RARE = "rare";
// Stats for the legendary puppy (shiba inu)
- string private legendaryImageUri = "ipfs://QmYx6GsYAKnNzZ9A6NvEKV9nf1VaDzJrqDR23Y8YSkebLU";
+ string private constant legendaryImageUri = "ipfs://QmYx6GsYAKnNzZ9A6NvEKV9nf1VaDzJrqDR23Y8YSkebLU";
uint256 public constant LEGENDARY_RARITY = 5;
string private constant LEGENDARY = "legendary";
Rewards breakdown
nSLOC
143This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.