First Flight #2: Puppy Raffle
First Flight #2
Beginner FriendlyFoundryNFT
100 EXP
View results
Previous Next
Submission Details
Severity: low
Invalid

Unused functions and code

aballok

Summary

Function and code defined but never used

Vulnerability Details

Internal function is never used or called in contracts

/// @notice this function will return true if the msg.sender is an active player
function _isActivePlayer() internal view returns (bool) {
for (uint256 i = 0; i < players.length; i++) {
if (players[i] == msg.sender) {
return true;
}
}
return false;
}

Impact

This may indicate missing logic which can have security implications. For example it may be the function was needed with better logic to check if user who got refund is activated off so they do not keep claiming refunds. Important thing is if it is unused its likely something may be wrong in the code, it can also affect auditability, readability and maintainability of code which al have security implications

Tools Used

Manual Analysis

Recommendations

Ensure code is used where needed or remove the function/code

Updates

Lead Judging Commences

Hamiltonite Lead Judge about 2 years ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!