First Flight #2: Puppy Raffle

Summary

This function is an internal function however it is not called anywhere in the code, meaning it can not ever be called or invoked, this it is wasting deployment gas by being included at all.

Vulnerability Details

N/A

Impact

this will increase the size of the contracts bytecode and will increase the cost of deployment.

Recommendations

This should technically be called here: https://github.com/Cyfrin/2023-10-Puppy-Raffle/blob/07399f4d02520a2abf6f462c024842e495ca82e4/src/PuppyRaffle.sol#L86
Or be removed from the code to reduce deployment size.

However this is a bad implementation, and it is much better
to use:
an isPlayerEntered mapping along with a players address array.