Submission Details
Severity:
refund function should pop players array
Summary
Basically it's best to move the refunded address to the end of the array and pop it , so that the array get's smaller and cost less gas when iterating over it!
Vulnerability Details
players[playerIndex] = address(0);
Impact
Low
Tools Used
Manual review
Recommendations
Move the refunded array to the end of the array and pop it.
Updates
Lead Judging Commences
patrickalphac about 2 years ago
Submission Judgement Published Assigned finding tags:
refund-doesnt-reduce-players-array-size-causing-protocol-to-freeze
zero address can win the raffle
Funds are locked to no one. If someone gets the refund issue, they also got this issue. IMPACT: High Likelihood: High
Rewards breakdown
nSLOC
143This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.