Submission Details
Severity:
`refund` function is not following CEI pattern, could have potential reentrancy
Summary
PuppyRaffle::refund function is not following CEI pattern to transfer the funds to players, a malicious actor could do reentrancy and steal all the funds.
Vulnerability Details
PuppyRaffle::refund function transferring the funds using sendValue first and then updating the player address to zero.
Impact
Could lose all the funds from contract.
Tools Used
Manual Review
Recommendations
Follow CEI pattern or use a reentrancy guard provided by openzepplin library.
Rewards breakdown
nSLOC
143This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.