Submission Details
Severity:
enterRaffle unable to know when vote duration has been reached so people will still be able to enter even past the deadline if winner hasn’t been selected yet
Summary
The enterRaffle function shouldn't allow anyone to enter the raffle after the vote duration has been reached. Otherwise if selectWinner hasn't been called yet people will still be able to enter the current raffle regardless.
Vulnerability Details
enterRaffle doesn't take into account when vote duration has been reached.
Impact
enterRaffle will allow people to enter raffle that is running even when the vote has ended.
Tools Used
Manual Review
Recommendations
function enterRaffle(address[] memory newPlayers) public payable {
+ require(block.timestamp < raffleStartTime + raffleDuration, "PuppyRaffle: Raffle is over");
// rest of the code
}
Updates
Lead Judging Commences
Hamiltonite about 2 years ago
Submission Judgement Published Reason: User experience and design improvement
Rewards breakdown
nSLOC
143This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.