Beginner FriendlyFoundryNFT
100 EXP
View results
Submission Details
Severity: low
Valid

Missing events - just a recommendation

Summary

I'd recommend adding in events for the selectWinner() and withdrawFees() functions

Vulnerability Details

These functions contain logic and state changes that could warrant being tracked offchain. For example maybe the feeRecipient wants to listen for when a winner is selected so they can go ahead and withdraw their fees.

Impact

Low - just a convenience but does not lead to loss of funds

Tools Used

Manual inspection

Recommendations

we can incorporate two new events

event WinnerSelected(address indexed winner);
event FeesWithdrawn(uint64 indexed fees);
Updates

Lead Judging Commences

Hamiltonite Lead Judge about 2 years ago
Submission Judgement Published
Validated
Assigned finding tags:

events are missing or not detailed enough

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!