First Flight #2: Puppy Raffle

Summary

entranceFee should have a minimum value.

Vulnerability Details

If the value is too small, then prizePool will be zero:

• Technically if players.length * entranceFee * totalAmountCollected < 100, then it will be 0.

• This is because solidity only do integer division, if there is a remainder, then it is discarded.

Impact

This is not a situation that occurs very often, as such impact is not high. But it is worth considering that under certain conditions, the prize pool or the fees could be zero. This could incur reputational damage for the protocol, and a very small amount of funds lost.

Tools Used

Manual Review.

Recommendations

Check for a minimum value for entranceFee in the constructor or increase the precision of the calculation.