Submission Details
Severity:
Reentrancy in selectWinner function
Summary
Reentrancy guard not present for SelectWinner function.
Vulnerability Details
selectWinner
function selectWinner() external { 👈 we're dealing with money & changing states here but without a Reentrancy Guard.
// statements...
// statements...
}
Impact
Raffle can misbehave, Winner might not be so random further more, Would not be considered a Fair Raffle (lottery).
Tools Used
Manual review
Recommendations
We should use openzeppelin library's utility called Reentrancy Guard.
See Below... 👇
selectWinner Reentrancy Guard Added
import {ReentrancyGuard} from "@openzeppelin/contracts/utils/ReentrancyGuard.sol";
//...
//...
//...
function selectWinner() external nonReentrant { 👈 here i added nonReentrant modifier.
// statements...
}
Updates
Lead Judging Commences
Hamiltonite about 2 years ago
Submission Judgement Published Assigned finding tags:
reentrancy-in-refund
reentrancy in refund() function
Rewards breakdown
nSLOC
143This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.