Beginner FriendlyFoundryNFT
100 EXP
View results
Submission Details
Severity: low
Valid

WithdrawFees function should emit event

Summary

The withdrawFees function should emit an event containing both the feeAddress(which is liable to change over the course of tiem), as well as the feesToWithdraw amount.

Vulnerability Details

N/A

Impact

It will not be practical to be able to get all past fee withdrawals, especially as the fee address can change.
This will lead to a significantly worse UserExperience from the point of view of the dapp developers and end users, but will not effect the contract logic at all.

Tools Used

Manual Review

Recommendations

emit an event like the following at the end of withdrawFees
event FeesWithdrawn(address feeAddress,uint256 totalFees);

Updates

Lead Judging Commences

patrickalphac Lead Judge about 2 years ago
Submission Judgement Published
Validated
Assigned finding tags:

events are missing or not detailed enough

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!