Submission Details
Severity:
Zero withdraw fees address
Summary
It would be really scary if owner update the feeAddress to a zero feeAddress by mistake. So it should not be possible.
Vulnerability Details
changeFeeAddress has zero address issue
function changeFeeAddress(address newFeeAddress) external onlyOwner {
// here 👈, This function must have a require check to protect owner against zero feeAddress update.
feeAddress = newFeeAddress;
emit FeeAddressChanged(newFeeAddress);
}
Impact
Owner or Fee recipient can loose his/her all Raffle Fees. Already it sounds horrible.
Tools Used
Manual review
Recommendations
changeFeeAddress with protection against zero `feeAddress` updation
function changeFeeAddress(address newFeeAddress) external onlyOwner {
require(newFeeAddress != address(0), "PuppyRaffle: Must be a valid non zero address"); // here 👈 🖐, I added a require check to stop owner against making disaster.
feeAddress = newFeeAddress;
emit FeeAddressChanged(newFeeAddress);
}
Rewards breakdown
nSLOC
143This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.