Beginner FriendlyFoundryNFT
100 EXP
View results
Submission Details
Severity: low
Valid

Events missing for critical functionality

Summary

Critical functionality and updates missing events

Vulnerability Details

Critical functions like selecting a winner(selectWinner) and withdrawing fees(withdrawFees) do not emit events

Impact

Events are critical for front ends, off chain tooling, monitoring and reporting and even security. For example if something is picked up in real time from events that is suspicious action can be taken to mitigate. However if there is no events then missed easy way to monitor, get alert real time activities of project disadvantaging security

Tools Used

Manual Analysis

Recommendations

Add events e.g

event WinnerSelected(address caller, address winner)
event WithdrawFees(address caller, address owner, uint256 amountFees)
Updates

Lead Judging Commences

patrickalphac Lead Judge
over 1 year ago
Hamiltonite Lead Judge over 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

events are missing or not detailed enough

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.