Submission Details
Severity:
in selectWinner, Should call _safeMint before sending ether
Summary
The NFT is minted after the ether is sent to the winner.
Vulnerability Details
There is no real potential exploit here because the .call is assured to revert if the transfer fails. and there should be no reentrancy issues because of this.
Impact
there is little to no impact. Just a matter of clean code and following best practices.
Tools Used
Manual Review
Recommendations
It is recommended to follow the Check-Effects-Interaction pattern and perform state changes before sending ether.
Rewards breakdown
nSLOC
143This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.