Submission Details
Severity:
imageUris should be constants
Summary
commonImageUri, rareImageUri and legendaryImageUri should be set as constants.
Vulnerability Details
commonImageUri, rareImageUri and legendaryImageUri are not updated following deployment should be declared constant to save gas.
// Stats for the common puppy (pug)
- string private commonImageUri = "ipfs://QmSsYRx3LpDAb1GZQm7zZ1AuHZjfbPkD6J7s9r41xu1mf8";
+ string private constant commonImageUri = "ipfs://QmSsYRx3LpDAb1GZQm7zZ1AuHZjfbPkD6J7s9r41xu1mf8";
uint256 public constant COMMON_RARITY = 70;
string private constant COMMON = "common";
// Stats for the rare puppy (st. bernard)
- string private rareImageUri = "ipfs://QmUPjADFGEKmfohdTaNcWhp7VGk26h5jXDA7v3VtTnTLcW";
+ string private constant rareImageUri = "ipfs://QmUPjADFGEKmfohdTaNcWhp7VGk26h5jXDA7v3VtTnTLcW";
uint256 public constant RARE_RARITY = 25;
string private constant RARE = "rare";
// Stats for the legendary puppy (shiba inu)
- string private legendaryImageUri = "ipfs://QmYx6GsYAKnNzZ9A6NvEKV9nf1VaDzJrqDR23Y8YSkebLU";
+ string private constant legendaryImageUri = "ipfs://QmYx6GsYAKnNzZ9A6NvEKV9nf1VaDzJrqDR23Y8YSkebLU";
uint256 public constant LEGENDARY_RARITY = 5;
string private constant LEGENDARY = "legendary";
Impact
The impact is low, more gas is just consumed.
Tools Used
Manual review
Recommendations
Add constant to save gas.
Rewards breakdown
nSLOC
143This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.