Submission Details
Severity:
getActivePlayerIndex function inefficiency
Summary
We want to avoid using for loops to iterate over arrays as it is expensive computation.
Vulnerability Details
Line 110 - 117 in PuppRaffle.Sol is using a for loop when a mapping is much more suitable.
Impact
Uneccesary gas cost
Tools Used
Manual inspection
Recommendations
Use a mapping instead of for loop
Updates
Lead Judging Commences
Hamiltonite almost 2 years ago
Submission Judgement Published Assigned finding tags:
getActivePlayerIndex can say a player is both entered at slot 0 and inactive
Rewards breakdown
nSLOC
143This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.