First Flight #2: Puppy Raffle

Summary

Reentrancy in refund function before the state variable update allows to withdraw funds from the contract

Vulnerability Details

In refund function calls msg.sender back with no gas limits. Reentrancy occurred before state variable players changed. This allows attacker to call refund function back again and withdraw all the funds from the contract

Impact

Funds withdrawing possibility

Tools Used

Recommendations

Transfer ether back after all the state variables updated