Beginner FriendlyFoundryNFT
100 EXP
View results
Submission Details
Severity: high
Invalid

Unnecessary initialization of totalFees

Summary

totalFees doesn't need to be explicitly initialized.

Vulnerability Details

totalFees = 0 is unnecessary operation, because the value of uint64 is zero by default

Impact

Low. Not a security issue, but takes extra gas for writing to storage.

Tools Used

Manual check.

Recommendations

Don't initialize explicitly. The following would work:

totalFees;
Updates

Lead Judging Commences

Hamiltonite Lead Judge almost 2 years ago
Submission Judgement Published
Invalidated
Reason: Gas optimizations
Assigned finding tags:

weak-randomness

Root cause: bad RNG Impact: manipulate winner

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.