Beginner FriendlyFoundryNFT
100 EXP
View results
Submission Details
Severity: low
Invalid

Unreachable `PuppyRaffle::_isActivePlayer` Function

Summary

_isActivePlayer is declared with internal visibility modifier and is not call from any other function.

Impact

Waste of gas of deployment and unnecessary bigger contract size.

Tools Used

Manual

Recommendations

The function has a similar logic to getActivePlayerIndex making it possibly redundant. My recommendation is to remove the function from the contract.

Updates

Lead Judging Commences

Hamiltonite Lead Judge almost 2 years ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.