Summary

There is a potential issue where exceeding the enterRaffle function's requirements can result from the combination of msg.value and entranceFee * newPlayers.length, possibly leading to an overflow. This issue needs attention to ensure accurate raffle entry and financial integrity.

POC

function testEnterRaffleOverflow() public { uint256 _entraceFee = (type(uint256).max / 2) + 1; PuppyRaffle tempPuppyRaffle = new PuppyRaffle(_entraceFee, feeAddress, duration); address[] memory players = new address[](2); players[0] = playerOne; players[1] = playerTwo; tempPuppyRaffle.enterRaffle(players); }

Recommendations

change sol version to at least 0.8.0