Summary

The enterRaffle function itterates over arrays three times and will revert if they become too long.

Vulnerability Details

Looping through arrays is gas intensive. The enterRaffle function does this three times. Once over the array passed by the user and twice over the player array to check for duplicates.

Impact

If either of these arrays is or becomes too large it will run out of gas. If a user passed an array of address who wishes to enter and it is too long they will have to split it into multiple function calls. But then when the players array becomes too long no new players will be able to enter the raffle

Tools Used

Manual Review

Recommendations

Only allow players to enter themselves into the raffle and track their entry with a bool. This would also disallow users from registering unwilling accounts into the raffle.