Beginner FriendlyFoundryNFT
100 EXP
View results
Submission Details
Severity: low
Invalid

Use of string constants instead of enum variables

Summary

Use of string constants instead of enum variables

Vulnerability Details

The contract defines rarity categories as string constants for the rarity levels of 'common', 'rare', and 'legendary'.

Impact

Using string constants might increase the possibility of human error and reduce code readability.

Recommendations

Consider using enum to define rarity levels. Enums will enhance code readability and decrease the probability of mistakes related to rarity definitions and logic related to the rarity.

// Rarity levels enum
enum Rarity {
COMMON,
RARE,
LEGENDARY
}
Updates

Lead Judging Commences

patrickalphac Lead Judge almost 2 years ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.