First Flight #2: Puppy Raffle

Summary

this function can be called at anyone by anytime, resulting in a 0 eth transfer call, and wasted gas.

Vulnerability Details

The function does not first check if the raffle is over or if a winner has been selected.

Impact

Low impact.
A user who mistakenly calls withdrawFees will find that it does not revert, but rather that it succeeds and that they have wasted gas on a empty eth call to the feeAddress.

Tools Used

Manual Review

Recommendations

Add a conditional check to see if selectWinner has been called, in the most recent raffle, or if the intention is to allow the fees to accumulate over time, to allow only the feeAddress to be able to call the withdraw fees function.