Submission Details
Severity:
`getActivePlayerIndex` return wrong value
Summary
function getActivePlayerIndex(address player) external view returns (uint256) return wrong value
Vulnerability Details
function getActivePlayerIndex(address player) external view returns (uint256) return 0 for not active player can
be duplicated with the player at index 0
Impact
The first player in the array players is always not active due to the return 0 value
Tools Used
manual
foundry
Recommendations
Instead of returning 0 for not active player this function should return int256 value
For example: return -1 if the player is not active
function getActivePlayerIndex(address player) external view returns (int256) {
for (int256 i = 0; i < int256(players.length); i++) {
if (players[uint256(i)] == player) {
return i;
}
}
return -1;
}
Updates
Lead Judging Commences
Hamiltonite about 2 years ago
Submission Judgement Published Assigned finding tags:
getActivePlayerIndex can say a player is both entered at slot 0 and inactive
Rewards breakdown
nSLOC
143This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.