First Flight #2: Puppy Raffle

Summary

No zero check in the changeFeeAddress function

Vulnerability Details

Location:

PuppyRaffle.changeFeeAddress(address).newFeeAddress (src/PuppyRaffle.sol#167) lacks a zero-check on :

• feeAddress = newFeeAddress (src/PuppyRaffle.sol#168)

Impact

If the owner's account is compromised, the attacker could redirect the fees to their own address.

Tools Used

Audit Wizard (Slither)

Recommendations

Check that the address is not zero.