First Flight #2: Puppy Raffle

Summary

Missing zero address check

Vulnerability Details

In the PuppyRaffle.sol contract constructor, where the _feeAddress is set, there should be a check condition that requires the passed address from the constructor to not be a zero address.

Impact

There is a possibility of transferring contract fees to a zero address later when the withdrawFees() function is clicked later; if not, a zero check is provided.

Tools Used

Manual Review

Recommendations

Consider adding a zero address check before setting the _feeAddress address property.