Beginner FriendlyFoundryNFT
100 EXP
View results
Submission Details
Severity: low
Valid

Missing `WinnerSelected`/`FeesWithdrawn` event emition in `PuppyRaffle::selectWinner`/`PuppyRaffle::withdrawFees` methods

Summary

Events for critical state changes (e.g. owner and other critical parameters like a winner selection or the fees withdrawn) should be emitted for tracking this off-chain

Tools Used

Manual review

Recommendations

Add a WinnerSelected event that takes as parameter the currentWinner and the minted token id and emit this event in PuppyRaffle::selectWinner right after the call to _safeMing_

Add a FeesWithdrawn event that takes as parameter the amount withdrawn and emit this event in PuppyRaffle::withdrawFees right at the end of the method

Updates

Lead Judging Commences

Hamiltonite Lead Judge about 2 years ago
Submission Judgement Published
Validated
Assigned finding tags:

events are missing or not detailed enough

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!