Submission Details
Severity:
Missing user input validation on `PuppyRaffle::changeFeeAddress` can lead to address(0) being set as the `feeAddress`.
Summary
Missing user input validation on PuppyRaffle::changeFeeAddress can lead to address(0) being set as the feeAddress.
Impact
This is a non-issue as ether can't be sent to address(0) and the owner only needs to set a new feeAddress and withdraw the fees there.
Tools Used
Manual review
Recommendations
function changeFeeAddress(address newFeeAddress) external onlyOwner {
+ require(newAddress != address(0), "fee address can not be the Zero address");
feeAddress = newFeeAddress;
emit FeeAddressChanged(newFeeAddress);
}
Updates
Lead Judging Commences
Hamiltonite about 2 years ago
Submission Judgement Published Reason: Zero address checks
Assigned finding tags:
weak-randomness
Root cause: bad RNG Impact: manipulate winner
Rewards breakdown
nSLOC
143This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.