Beginner FriendlyFoundryNFT
100 EXP
View results
Submission Details
Severity: medium
Invalid

Critical owner address change in a one-step process is risky

Summary

Critical owner address change in a one-step process is risky.

Vulnerability Details

The contracts lack two-step role transfer.
Contract ownership plays a critical role in the protocol. The ownership management of this contract defaults to Ownable’s transferOwnership and renounceOwnership methods. Such critical address changing in one step is risky because it is irrecoverable from any mistakes.

Impact

It is irrecoverable if the owner is set to the wrong address.

Tools Used

Manual review.

Recommendations

It is recommended to implement a two-step role transfer where the role recipient is set and
then the recipient has to claim that role to finalize the role transfer.

Updates

Lead Judging Commences

patrickalphac Lead Judge about 2 years ago
Submission Judgement Published
Invalidated
Reason: User experience and design improvement

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!