First Flight #2: Puppy Raffle

Summary

The selectWinner() function in the PuppyRaffle contract uses integer division to calculate the prize pool and fee. This can result in precision loss.

Vulnerability Details

The code calculates the fee variable as a percentage of totalAmountCollected using integer arithmetic. This can result in precision loss, especially if totalAmountCollected is not a multiple of 100. The code increments totalFees with the potentially imprecise fee value,which can lead to cumulative inaccuracies in the calculation of fees over time.

Impact

Precision loss can lead to inaccurate results

Tools Used

Manual analysis

Recommendations

The selectWinner() function should be updated to use fixed-point arithmetic to calculate the prize pool and fee. This will ensure that the results are accurate to the desired precision.