First Flight #2: Puppy Raffle

Summary

WithdrawFees function has a check for balance of the contract is equal to the totalFees to allow withdrawing. This makes no sense as totalFees are already separated than the refund round. Anyone can front run the withdrawFees function by entering the raffle or just by self destructing another contract and increasing the balance of the contract, preventing to withdraw the fees.

Impact

Possibility of not being able to withdraw the fees

Recommendations

As the new round's fees are not assigned before the round is over, there is no need to check if totalFees is equal to contract balance. removing this check will solve the issue.