Submission Details
Severity:
Risk of silent overflow
Summary
Vulnerability Details
In the PuppyRaffle.sol selectWinner(),the uint256fee is forcefully cast to uint64.
In the 2023-07-PoolTogether contest on C4, there is relevant and valid finding for this issue.
You can find it here:
https://code4rena.com/reports/2023-07-pooltogether#m-19-silent-overflow-could-alter-computation-when-calculating-the-vaultportion-in-the-prizepool-contract
Impact
This can potentially result in a silent overflow and may lead to totalFees goes wrong.
Tools Used
Recommendations
Add checks that the casting value is not greater than the uint64 type max value:
if (fee > type(uint64).max) {Overflow();}
Rewards breakdown
nSLOC
143This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.