Submission Details
Severity:
`_isActivePlayer` is not working as intended
Summary
_isActivePlayer internal visibility restricts it's functionality as described by the NATSPEC
Vulnerability Details
_isActivePlayer is meant to return true if the msg.sender is an active player according to NATSPEC but it's visibility is internal which means it can be called only by the contract and all the contracts that inherit from it. The _isActivePlayer function is never called internally.
Impact
_isActivePlayer can't be used as intended.
Tools Used
Manual review
Recommendations
/// @notice this function will return true if the msg.sender is an active player
-- function _isActivePlayer() internal view returns (bool) {
++ function isActivePlayer() external view returns (bool) {
for (uint256 i = 0; i < players.length; i++) {
if (players[i] == msg.sender) {
return true;
}
}
return false;
}
Rewards breakdown
nSLOC
143This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.