First Flight #2: Puppy Raffle

Summary

LOW-2: The constructor variable _raffleDuration might consider being limited with the lowest/highest value to avoid excessively long/short durations of the raffles.

Vulnerability Details

Currently, the _raffleDuration is defined as a uint256 value that may contain very high values. To avoid raffles taking an unbearably long time, it may be considered to create limits on the minimum and maximum duration.

Impact

This issue may impact user satisfaction/experience with the contract.

Tools Used

Static analysis

Recommendations

Recommend adding require statements requiring the _raffleDuration variable to be within reasonable values (i.e. 1 minute and 7 days).