First Flight #2: Puppy Raffle

Summary

MEDIUM-1: As per the specifications, point 1.1 says "[...] You can use this to enter yourself multiple times, or yourself and a group of your friends."

Point 2 however says "Duplicate addresses are not allowed" which stays in direct opposition to the first statement.

Vulnerability Details

Inconsistency of the contract goal and procedures

Impact

A potential risk for the users, unclear explanation and rules leading to an impact on user experience

Tools Used

Static analysis

Recommendations

Clarify the rules - if there is no possibility for the same address to enter twice you may register as many times as you want. Given the fact that the user may create many different addresses, I would recommend dropping the rule and allowing duplicates. This will also save gas costs due to the removal of the nested for loop.