First Flight #2: Puppy Raffle

Summary

entranceFee by the user is not added to the totalFees variable, which will result in a loss of funds

Vulnerability Details

In the PuppyRaffle::enterRaffle() function, the users are sending a given amount of money in order to join the raffle. The problem is that the value sent from the users (msg.value) is not added to the totalFees address, which is a variable that is responsible for storing the protocol fee amount. This issue will cause a loss of funds for the protocol and the user with the 'fee address' to which the fees are transferred.

Impact

Loss of funds for the protocol and the user with the feeAddress

Tools Used

Manual Review

Recommendations

Consider adding the msg.value amount send from the users transaction to the totalFees state variable.