Submission Details
Severity:
`PuppyRaffle::raffleDuration, raffleStartTime` being set as a storage variable
Summary
PuppyRaffle::raffleDuration, raffleStartTime these variables can't be changed. In order to save gas they both should be immutable variables.
Vulnerability Details
contract PuppyRaffle is ERC721, Ownable {
using Address for address payable;
uint256 public immutable entranceFee;
address[] public players;
@> uint256 public raffleDuration;
@> uint256 public raffleStartTime;
address public previousWinner;
Impact
Wastes gas.
Tools Used
-Manual Analysis
Recommendations
- uint256 public raffleDuration;
+ uint256 public immutable raffleDuration;
- uint256 public raffleStartTime;
+ uint256 public immutable raffleStartTime;
Rewards breakdown
nSLOC
143This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.