Beginner FriendlyFoundryNFT
100 EXP
View results
Submission Details
Severity: low
Valid

Events missing caller information

Summary

Events do not give information of the caller of the function

Vulnerability Details

Events are critical and need to be as complete as possible. Events must emit the caller of the function in which the event was emitted. Events are missing the caller emitted as msg.sender

Impact

Disadvantages offchain tooling, front ends, monitoring, reporting and even security tools which may rely on observing if caller is appropriate real time so action can be taken in case something is not as expected.

Tools Used

Manual Analysis

Recommendations

Events must emit the caller of the function by ensuring they pass and emit msg.sender variable e.g

// address caller emitted as msg.sender in the respective functions
event RaffleEnter(address caller, address[] newPlayers);
event RaffleRefunded(address caller, address player);
event FeeAddressChanged(address caller, address newFeeAddress);
Updates

Lead Judging Commences

Hamiltonite Lead Judge over 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

events are missing or not detailed enough

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.