First Flight #2: Puppy Raffle

Summary

While the raffle is ongoing/continuous, the withdrawFees() function will be DoS'ed.

Vulnerability Details

The raffle will need to be paused to call this function successfully, due to the following line, which effectively makes it impossible to call because address(this).balance == uint256(totalFees) can only ever be true between the end of current raffle, i.e. at end of winner selection function, and before the start of the next raffle, but the next raffle starts as soon as the winner selection function ends. So it effectively DoS the withdrawFees() function.

Impact

Cant withdraw fees while raffles are ongoing.

Tools Used

VSC.

Recommendations

Add a function(s) to pause/unpause the raffle train...