First Flight #2: Puppy Raffle

Summary

totalSupply() not implemented at all, will cause compiler error.

Vulnerability Details

Since totalSupply() not implemented in PuppyRaffle contract or the relevant ERC721Enumerable extension contract not imported, the solidity compiler will errorrr.

Impact

Contract won't compile.
And IF the contract magically compiles, the index of the NFT will be zero always.

Tools Used

VSC.

Recommendations

Either implement the totalSupply() in the PuppyRaffle contract and import the IERC721Enumerable interface, or import and inherit the ERC721Enumerable contract to use totalSupply() in the PuppyRaffle contract.

import {IERC721Enumerable} from "./IERC721Enumerable.sol";
OR
import {ERC721Enumerable} from "./ERC721Enumerable.sol";