Submission Details
Severity:
feeAddress can be set to address(0)
Summary
The lack of address(0) validation can lead to loss of fees.
Vulnerability Details
Since there is no validation for address(0) in the constructor and in the changeFeeAddress, the feeAddress can be set to address(0) by mistake.
Impact
In withdrawFees we use the feeAddress to send all the fee collected by the smart contract. If it is set to address(0) all these fees will be lost.
Tools Used
Manual Review
Recommendations
Add address(0) checks in the places where we set the feeAddress.
@audit add this in the constructor
require(_feeAddress != address(0), Address 0);
@audit add this in the changeFeeAddress
require(newFeeAddress != address(0), Address 0);
Rewards breakdown
nSLOC
143This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.