Submission Details
Severity:
selectWinner() - unsafe casting of `fee` from `uint256` down to `uint64`.
Summary
selectWinner() - unsafe casting of fee from uint256 down to uint64.
Vulnerability Details
If the fee is a value larger than type uint64 max, the casting will cause overflow and result in no fees being added.
Also, if the fee is smaller than uint64 max but large enough so that totalFees + uint64(fee) > type(uint64).max, it will also overflow and result in zero total fees.
Low severity because it's highly unlikely to ever reach a fee value anywhere close enough.
totalFees = totalFees + uint64(fee);
Impact
Zero fees will be recorded if the near impossible happens.
address(this).balance and totalFees will be perpetually out of sync.
Tools Used
VSC.
Recommendations
if (fee < type(uint64).max) {
totalFees = totalFees + uint64(fee);
} else {
// Handle the case where the fee is too large to fit in a uint64
}
Updates
Lead Judging Commences
Hamiltonite about 2 years ago
Submission Judgement Published Assigned finding tags:
unsafe cast of fee to uint64
Rewards breakdown
nSLOC
143This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.