Beginner FriendlyFoundryNFT
100 EXP
View results
Submission Details
Severity: low
Invalid

_isActivePlayer() - Internal function not being called internally at all.

Summary

_isActivePlayer() - Internal function not being called internally at all.

Vulnerability Details

/// @notice this function will return true if the msg.sender is an active player
function _isActivePlayer() internal view returns (bool) {

Impact

Absence of intended functionality.
OR
Unnecessary additional gas costs during contract deployment.

Tools Used

VSC.

Recommendations

If it's meant to be external function, it should be changed to external modifier, but I suspect the intention was for it to be called internally only.
It's not being used in any other functions within the contract. Should either be removed or its intended implementation/use case fully implemented or it should be commented out.

Updates

Lead Judging Commences

Hamiltonite Lead Judge over 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.