Beginner FriendlyFoundryNFT
100 EXP
View results
Submission Details
Severity: low
Valid

Event should have old and new value as parameters.

Summary

Events emitted when state is change, should contain both the old and the new value.

Tools Used

Manual Review

Recommendations

Do the following:

- event FeeAddressChanged(address newFeeAddress);
+ event FeeAddressChanged(address oldFeeAddress, address newFeeAddress);
- feeAddress = newFeeAddress;
- emit FeeAddressChanged(newFeeAddress);
+ address oldFeeAddress = feeAddress;
+ feeAddress = newFeeAddress;
+ emit FeeAddressChanged(oldFeeAddress, newFeeAddress);
Updates

Lead Judging Commences

Hamiltonite Lead Judge over 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

events are missing or not detailed enough

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.