Submission Details
Severity:
Redundant require() check in refund()
Summary
There is a redundant require() check in the refund() method that will always be true and can be removed
Vulnerability Details
The first statement checks that playerAddress == msg.sender and the second statement check playerAddress != address(0). The msg.sender can never be address(0). Hence it's a redundant check that can be removed.
require(playerAddress == msg.sender, "PuppyRaffle: Only the player can refund");
require(playerAddress != address(0), "PuppyRaffle: Player already refunded, or is not active");
Recommendations
The second require() statement can be removed.
Rewards breakdown
nSLOC
143This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.