Submission Details
Severity:
Potential DoS on Unbounded player loop
Summary
When enterRaffle function invoked, all player will be traversed in the loop, which may run out the gas
Vulnerability Details
// Check for duplicates
for (uint256 i = 0; i < players.length - 1; i++) { //@audit gas dos with unbounded loop
for (uint256 j = i + 1; j < players.length; j++) {
require(players[i] != players[j], "PuppyRaffle: Duplicate player");
}
}
Impact
DoS on the enterRaffle function
Tools Used
Manual
Recommendations
Set upperbound for the user may join, and limit number of new player for each batch.
Updates
Lead Judging Commences
Hamiltonite about 2 years ago
Submission Judgement Published Assigned finding tags:
denial-of-service-in-enter-raffle
Rewards breakdown
nSLOC
143This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.