First Flight #2: Puppy Raffle

Summary

enterRaffle can be called with an empty array

Vulnerability Details

Since the function only requires us to pay as much as fee * newPlayers.length, we can call this function with an empty array.

Impact

Low. It causes new events to be emitted with an empty array, thus cluttering the logs with trash.

Tools Used

n/a

Recommendations

Add another require(newPlayers.length > 0) at the top of the function to prevent the function from being called with no new players;